Skip to content

Commit 2f7d04e

Browse files
authored
tree schema BUGFIX module revision invalid order message (#2547)
The [standard](https://datatracker.ietf.org/doc/html/rfc7950#section-7.1.9) says that: > [...] a new [revision] SHOULD be added in front of the revisions > sequence so that all revisions are in reverse chronological order The actual error message was misleading, saying that an older revision was found after a new revision. That is actually a correct order. The check was correct, but the error message should have said that the older revision was found *before* a newer one. We actually "fixed" our YANG models based on this diagnostic message, only to revert that later on.
1 parent 728958a commit 2f7d04e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/tree_schema_common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ lysp_last_revision(const struct lysp_module *pmod, const struct lysp_revision *r
9191
cmp = strcmp(revs[u].date, revs[u + 1].date);
9292
if (cmp < 0) {
9393
if (ctx) {
94-
LOGWRN(ctx, "Older revision %s found after a newer revision %s in %s \"%s\".", revs[u].date,
94+
LOGWRN(ctx, "Older revision %s found before a newer revision %s in %s \"%s\".", revs[u].date,
9595
revs[u + 1].date, mod_str, name);
9696
}
9797

0 commit comments

Comments
 (0)