Skip to content

Commit 7df568d

Browse files
committed
Attempt to fix arm builds
This commit updates the build workflow's script that executes our build script inside a debian docker container using the '--privileged' argument. This isn't really a security risk, because: 1. We only use docker for the purposes of getting a reproducible build, regardless of which linux baremetal we're running on (on GitHub it's a moving target of Ubuntu that we can't always pin) 2. CI Runners should be untrusted (thanks to reproducible builds) and ephemeral. So we give them full root permissions and don't have to trust the resulting build Anyway, this is necessary so that the docker container can have access to fuse, for AppImage building. For more info, see: * #32 (comment) * #40 (comment)
1 parent 56075b0 commit 7df568d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

build/linux/debianWrapper.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ set -x
1010
#
1111
# Authors: Michael Altfield <michael@buskill.in>
1212
# Created: 2020-10-03
13-
# Updated: 2024-03-17
14-
# Version: 0.4
13+
# Updated: 2026-07-04
14+
# Version: 0.5
1515
################################################################################
1616

1717
############
@@ -86,7 +86,7 @@ fi
8686
# docker container
8787
rm -rf /tmp/kivy_appdir
8888

89-
docker run --rm --cap-add "NET_ADMIN" -v "`pwd`:/root/buskill-app" -v "/tmp/kivy_appdir:/tmp/kivy_appdir" ${DOCKER_IMAGE_NAME} /bin/bash -c "cd /root/buskill-app && build/linux/buildAppImage.sh"
89+
docker run --privileged --rm --cap-add "NET_ADMIN" -v "`pwd`:/root/buskill-app" -v "/tmp/kivy_appdir:/tmp/kivy_appdir" ${DOCKER_IMAGE_NAME} /bin/bash -c "cd /root/buskill-app && build/linux/buildAppImage.sh"
9090

9191
###########
9292
# CLEANUP #

0 commit comments

Comments
 (0)