From e33c21f9ee59eeeac8b0d80a7dadb9656b07aaf0 Mon Sep 17 00:00:00 2001 From: David Baker Effendi Date: Fri, 21 Aug 2026 15:15:16 +0200 Subject: [PATCH] Retire the expected failure on the C++ macro-expanded call The annotation recorded that reverse navigation from the PARITY_CALL macro argument did not resolve to the expanded_label definition. Bifrost v0.10.5 resolves it to the authored include/parity.h:45:20, so the claim is stale and the case is now an ordinary pass. Measured over the 110-case balanced core: under v0.10.1 the usage-to- declaration lookup returned no_definition and the case reported expected_failure; under v0.10.5 it returns ok at the expected target and the runner reports improved, which is exactly the signal that an expectation has outlived the defect it described. The authored contract does not change. The declaration, expected usage, and lookup are untouched -- only the assertion about what Bifrost cannot do goes away. The review notes keep the retired reason and the evidence for retiring it, so the record survives rather than the annotation being deleted silently. Verified: validate passes 61 case files, and cpp-lsp-parity now runs 6 passed, 0 improved, 0 expected failures, with the pre-existing cpp-parity-using-alias-constructor gap unchanged. Co-Authored-By: Claude Opus 5 --- benchmarks/cases/cpp-lsp-parity.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/benchmarks/cases/cpp-lsp-parity.yaml b/benchmarks/cases/cpp-lsp-parity.yaml index 2dbb282..00049b6 100644 --- a/benchmarks/cases/cpp-lsp-parity.yaml +++ b/benchmarks/cases/cpp-lsp-parity.yaml @@ -334,8 +334,6 @@ cases: Upstream reference: clang-tools-extra/clangd/unittests/XRefsTests.cpp macro and function-reference scenarios. Server profile: clangd 22.1.6; measured locally with Apple clangd 21.0.0 (clang-2100.1.1.101). - id: cpp-parity-function-like-macro-expanded-call - expectedFailure: - reason: Bifrost finds the PARITY_CALL function-name argument as a line-level usage, but reverse navigation from that macro argument does not resolve to the expanded_label definition. declaration: location: uri: benchmark://source/include/parity.h @@ -384,6 +382,14 @@ cases: Upstream reference: clang-tools-extra/clangd/unittests/XRefsTests.cpp macro-expansion references and definition scenarios. Server profile: clangd 22.1.6; measured locally with Apple clangd 21.0.0 (clang-2100.1.1.101). Maturity: expanded_label is a file-backed macro argument that PARITY_CALL expands into a normal function call; no virtual document is required. + Expected-failure retired on 2026-08-21. The annotation recorded that + reverse navigation from the macro argument did not resolve to the + expanded_label definition. Bifrost v0.10.5 + (d775e3b4656f418c7025c06577ce707e1556da91) resolves it to the authored + include/parity.h:45:20, measured over the 110-case balanced core + against v0.10.1, where the same lookup returned no_definition. The + authored contract is unchanged; only the claim about what Bifrost + cannot do was stale. - id: cpp-parity-compile-commands-unsupported unsupported: reason: This configured regression case requires -DENABLE_PARITY_FEATURE and is excluded from default cross-tool scoring; run it explicitly with adapters/lsp/clangd-configured.json and --include-unsupported.