From ed169560a614db7a69035e027ea62609b704e212 Mon Sep 17 00:00:00 2001 From: Saurabh Sharma Date: Thu, 26 Dec 2024 21:44:43 +0530 Subject: [PATCH 1/3] MM-61633: Add aria-label in the onboarding button --- .../components/onboarding_tasklist/onboarding_tasklist.tsx | 4 +++- webapp/channels/src/i18n/en.json | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx b/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx index 7a82866a5c40..27e454caab7a 100644 --- a/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx +++ b/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx @@ -2,7 +2,7 @@ // See LICENSE.txt for license information. import React, {useRef, useCallback, useEffect, useState} from 'react'; -import {FormattedMessage} from 'react-intl'; +import {FormattedMessage, useIntl} from 'react-intl'; import {useDispatch, useSelector} from 'react-redux'; import styled, {css} from 'styled-components'; @@ -124,6 +124,7 @@ const Button = styled.button<{open: boolean}>(({open}) => { }); const OnBoardingTaskList = (): JSX.Element | null => { + const {formatMessage} = useIntl(); const hasPreferences = useSelector((state: GlobalState) => Object.keys(getMyPreferencesSelector(state)).length !== 0); useEffect(() => { @@ -253,6 +254,7 @@ const OnBoardingTaskList = (): JSX.Element | null => { ref={trigger} open={open} data-cy='onboarding-task-list-action-button' + aria-label={formatMessage({id:'onboardingTask.checklist.start_onboarding_process', defaultMessage:'Start the onboarding process.'})} > {open ? : } {itemsLeft !== 0 && ({itemsLeft})} diff --git a/webapp/channels/src/i18n/en.json b/webapp/channels/src/i18n/en.json index dbfe020d3a79..171b156a544d 100644 --- a/webapp/channels/src/i18n/en.json +++ b/webapp/channels/src/i18n/en.json @@ -4562,6 +4562,7 @@ "onboardingTask.checklist.task_learn_more_about_messaging": "Take a tour of Channels.", "onboardingTask.checklist.task_start_enterprise_trial": "Learn more about Enterprise-level high-security features.", "onboardingTask.checklist.task_visit_system_console": "Visit the System Console to configure your workspace.", + "onboardingTask.checklist.start_onboarding_process": "Start the onboarding process.", "onboardingTask.completeYourProfileTour.Description": "Use this menu item to update your profile details and security settings.", "onboardingTask.completeYourProfileTour.title": "Edit your profile", "onboardingTask.visitSystemConsole.Description": "More detailed configuration settings for your workspace can be accessed here.", From b47440f62afd66dd2e5222bed626f5a1f75999b3 Mon Sep 17 00:00:00 2001 From: Saurabh Sharma Date: Thu, 26 Dec 2024 22:04:54 +0530 Subject: [PATCH 2/3] MM-61633: Update formatting --- .../src/components/onboarding_tasklist/onboarding_tasklist.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx b/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx index 27e454caab7a..bf2a0bfe4a41 100644 --- a/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx +++ b/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx @@ -254,7 +254,7 @@ const OnBoardingTaskList = (): JSX.Element | null => { ref={trigger} open={open} data-cy='onboarding-task-list-action-button' - aria-label={formatMessage({id:'onboardingTask.checklist.start_onboarding_process', defaultMessage:'Start the onboarding process.'})} + aria-label={formatMessage({id: 'onboardingTask.checklist.start_onboarding_process', defaultMessage: 'Start the onboarding process.'})} > {open ? : } {itemsLeft !== 0 && ({itemsLeft})} From 574e7fb7e151a70a077f0bc69332f5ff6e73c34c Mon Sep 17 00:00:00 2001 From: Saurabh Sharma Date: Fri, 27 Dec 2024 13:13:23 +0530 Subject: [PATCH 3/3] MM-61633: Add strings for localization --- webapp/channels/src/i18n/en.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapp/channels/src/i18n/en.json b/webapp/channels/src/i18n/en.json index 171b156a544d..204a34b68e4c 100644 --- a/webapp/channels/src/i18n/en.json +++ b/webapp/channels/src/i18n/en.json @@ -4556,13 +4556,13 @@ "onboardingTask.checklist.main_subtitle": "Let's get up and running.", "onboardingTask.checklist.no_thanks": "No, thanks", "onboardingTask.checklist.start_enterprise_now": "Start your free Enterprise trial now!", + "onboardingTask.checklist.start_onboarding_process": "Start the onboarding process.", "onboardingTask.checklist.task_complete_your_profile": "Complete your profile.", "onboardingTask.checklist.task_download_mm_apps": "Download the Desktop and Mobile Apps.", "onboardingTask.checklist.task_invite_team_members": "Invite team members to the workspace.", "onboardingTask.checklist.task_learn_more_about_messaging": "Take a tour of Channels.", "onboardingTask.checklist.task_start_enterprise_trial": "Learn more about Enterprise-level high-security features.", "onboardingTask.checklist.task_visit_system_console": "Visit the System Console to configure your workspace.", - "onboardingTask.checklist.start_onboarding_process": "Start the onboarding process.", "onboardingTask.completeYourProfileTour.Description": "Use this menu item to update your profile details and security settings.", "onboardingTask.completeYourProfileTour.title": "Edit your profile", "onboardingTask.visitSystemConsole.Description": "More detailed configuration settings for your workspace can be accessed here.",