[Feature] Display server error when loading invalid URLs

[zonia3000]

I noticed that in Viewer.jsx the source error is displayed only when it is not an array:

  } else if (!Array.isArray(sourceErrors) && sourceErrors) {
    return (
      <div className="alert alert-danger" role="alert">
        {sourceErrors.message}
      </div>
    );
  }

This implementation allows us to see the error message No source provided, but it does not account for server errors such as 404 Not Found, 401 Unauthorized, and 403 Forbidden. Indeed, in these cases, the sourceErrors variable is an array containing a single element.

I found that I can view these errors by modifying hooks.js to replace setErrors(errors) with:

setErrors(errors.length === 1 ? errors[0] : errors);

With this change, the error messages are displayed as follows:

• 404: Node not found: v2 group
• 401: Unexpected response status 401 Unauthorized

Changing the setErrors call is a quick fix, but I wonder if you are considering a solution that would allow to support the multiple error messages case.

[davehorsfall]

Thanks for reporting @zonia3000 . Just a note that this Issue has been transferred to the new Vizarr repo, which will be our main viewer moving forwards. We will use this Issue to track general work to improve the error handling and reporting for the user. We might have time to look at this today at the Hackathon!

[davehorsfall]

This is related to #46, which aims to establish a broader framework for handling errors.

However, would be useful for @AlexSurtees to directly address the 3 cases of 404, 401, and 403 for source urls, and try to support @zonia3000's requests above.

[AlexSurtees]

@zonia3000 These http errors are now being handled in a more informative fashion in the under-review PR #95. You should be able to test the changes here https://deploy-preview-95--biongff-vizarr.netlify.app/

[zonia3000]

Thanks, we did some tests and the error messages are good for us.