Retrigger works only partially

[klangmodulator]

Tried to use the retrigger feature of the midithing v2.1. Unfortunately the retrigger ON doesn't work in MONO mode, in DUAL mode only on the first voice and in QUAD mode only on first 3 voices.

I think I spotted the reason: in the function MIDICV::playNote() the gate pin is used as an index for the Retrig array, ranging between 2 to 5. In the ProcessTrigger() function in firmware.ino this array is parsed from 1 to GS.NumVoices.

[xustafu]

Seems like a bug indeed. Checking it, will come back to you the soonest!

[xustafu]

Completely forgot to adress this issue!!! There was a firmware change but not uploaded, sorry!
Can you please check if Test branch solves your issue?
https://github.com/Befaco/midithing/tree/Test

[klangmodulator]

Thanks for coming back on it. I tested it in MONO/DUAL/QUAD mode and yes, the retrigger works now as it should! cool

The only thing I had to change was to rename the include file #include <mcp4728.h> to #include <MCP4728.h> so that the sketch compiled on my machine (built with Arduino 1.8.16 on Win10 and I installed the MCP4728 arduino library version 0.1.0 by "hideakitai")