From c1c052ba6f68ddb328f320e6907f2773237e6f1b Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 8 Dec 2022 13:30:12 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- utils.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/utils.py b/utils.py index 8d29742..5d63e3b 100644 --- a/utils.py +++ b/utils.py @@ -32,4 +32,23 @@ def extract_targz(targz_file_path): else: print('Extracting', targz_file_path) with tarfile.open(targz_file_path, 'r:gz') as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar)