Skip to content

Commit 9ca6bc8

Browse files
committed
fix: corriger la logique de nettoyage des ressources et mettre à jour les noms d'enregistrement d'application
1 parent db6c967 commit 9ca6bc8

3 files changed

Lines changed: 4 additions & 18 deletions

File tree

labs/mcp-prm-oauth/clean-up-resources.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
"import utils\n",
2121
"\n",
2222
"deployment_name = os.path.basename(os.path.dirname(globals()['__vsc_ipynb_file__']))\n",
23-
"resource_group = f\"lab-{deployment_name}-115\"\n",
23+
"resource_group = f\"lab-{deployment_name}\"\n",
2424
"\n",
2525
"utils.cleanup_resources(deployment_name, resource_group_name=resource_group)\n",
2626
"\n",
2727
"# The lab also creates an Entra ID app registration for the MCP endpoint (when you don't bring your own `mcpClientId`). It lives in Microsoft Entra ID, not in the resource group, so it must be deleted separately.\n",
2828
"\n",
29-
"app_registration_name = f\"lab-{deployment_name}-app4135676\"\n",
29+
"app_registration_name = f\"lab-{deployment_name}-app\"\n",
3030
"\n",
3131
"print(f\"Searching for app with display name {app_registration_name}...\")\n",
3232
"output = utils.run(f\"az ad app list --filter \\\"displayName eq '{app_registration_name}'\\\"\", \"Retrieved app registration\", \"Failed to get the app registration\")\n",
@@ -54,7 +54,7 @@
5454
"name": "python",
5555
"nbconvert_exporter": "python",
5656
"pygments_lexer": "ipython3",
57-
"version": "3.12.13"
57+
"version": "3.12.-1"
5858
}
5959
},
6060
"nbformat": 4,

labs/mcp-prm-oauth/mcp-prm-oauth.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@
335335
"name": "python",
336336
"nbconvert_exporter": "python",
337337
"pygments_lexer": "ipython3",
338-
"version": "3.12.13"
338+
"version": "3.12.-1"
339339
}
340340
},
341341
"nbformat": 4,

shared/utils.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -140,20 +140,6 @@ def cleanup_resources(deployment_name, resource_group_name = None):
140140
output = run(f"az keyvault delete -n {resource['name']} -g {resource_group_name}", f"Key Vault '{resource['name']}' deleted", f"Failed to delete Key Vault '{resource['name']}'")
141141
output = run(f"az keyvault purge -n {resource['name']} --location \"{resource['location']}\"", f"Key Vault '{resource['name']}' purged", f"Failed to purge Key Vault '{resource['name']}'")
142142

143-
# Delete Container Apps first, then their managed environments
144-
output = run(f"az containerapp list -g {resource_group_name}", f"Listed Container Apps", f"Failed to list Container Apps")
145-
if output.success and output.json_data:
146-
for resource in output.json_data:
147-
print_info(f"Deleting Container App '{resource['name']}' in resource group '{resource_group_name}'...")
148-
output = run(f"az containerapp delete -n {resource['name']} -g {resource_group_name} -y", f"Container App '{resource['name']}' deleted", f"Failed to delete Container App '{resource['name']}'")
149-
150-
# Delete Container Apps environments after the apps have been removed
151-
output = run(f"az containerapp env list -g {resource_group_name}", f"Listed Container Apps environments", f"Failed to list Container Apps environments")
152-
if output.success and output.json_data:
153-
for resource in output.json_data:
154-
print_info(f"Deleting Container Apps environment '{resource['name']}' in resource group '{resource_group_name}'...")
155-
output = run(f"az containerapp env delete -n {resource['name']} -g {resource_group_name} -y", f"Container Apps environment '{resource['name']}' deleted", f"Failed to delete Container Apps environment '{resource['name']}'")
156-
157143
# Delete the resource group last
158144
print_message(f"🧹 Deleting resource group '{resource_group_name}'...")
159145
output = run(f"az group delete --name {resource_group_name} -y", f"Resource group '{resource_group_name}' deleted", f"Failed to delete resource group '{resource_group_name}'")

0 commit comments

Comments
 (0)