From 88b30284b2665a40295df9fad28348fec3edb100 Mon Sep 17 00:00:00 2001 From: Siegfried Pammer Date: Sun, 31 May 2026 18:15:57 +0200 Subject: [PATCH 1/2] Add missing implementation of ScrollToHorizontalOffset/ScrollToVerticalOffset --- src/AvaloniaEdit/TextEditor.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/AvaloniaEdit/TextEditor.cs b/src/AvaloniaEdit/TextEditor.cs index aac323a1..2167bed6 100644 --- a/src/AvaloniaEdit/TextEditor.cs +++ b/src/AvaloniaEdit/TextEditor.cs @@ -827,8 +827,8 @@ public void ScrollToHome() public void ScrollToHorizontalOffset(double offset) { ApplyTemplate(); // ensure scrollViewer is created - //if (scrollViewer != null) - // scrollViewer.ScrollToHorizontalOffset(offset); + if (ScrollViewer is { } scrollViewer) + scrollViewer.Offset = scrollViewer.Offset.WithX(offset); } /// @@ -837,8 +837,8 @@ public void ScrollToHorizontalOffset(double offset) public void ScrollToVerticalOffset(double offset) { ApplyTemplate(); // ensure scrollViewer is created - //if (scrollViewer != null) - // scrollViewer.ScrollToVerticalOffset(offset); + if (ScrollViewer is { } scrollViewer) + scrollViewer.Offset = scrollViewer.Offset.WithY(offset); } /// From 8a1b229fb4a0cf20ccef5c9f86139f035ed466a6 Mon Sep 17 00:00:00 2001 From: Siegfried Pammer Date: Sun, 31 May 2026 18:37:05 +0200 Subject: [PATCH 2/2] Add missing implementations for LineDown, LineUp, LineLeft, LineRight, PageDown, PageUp, PageLeft, PageRight --- src/AvaloniaEdit/TextEditor.cs | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/AvaloniaEdit/TextEditor.cs b/src/AvaloniaEdit/TextEditor.cs index 2167bed6..d936f1d4 100644 --- a/src/AvaloniaEdit/TextEditor.cs +++ b/src/AvaloniaEdit/TextEditor.cs @@ -711,8 +711,8 @@ public void EndChange() /// public void LineDown() { - //if (scrollViewer != null) - // scrollViewer.LineDown(); + ApplyTemplate(); // ensure scrollViewer is created + ScrollViewer?.LineDown(); } /// @@ -720,8 +720,8 @@ public void LineDown() /// public void LineLeft() { - //if (scrollViewer != null) - // scrollViewer.LineLeft(); + ApplyTemplate(); // ensure scrollViewer is created + ScrollViewer?.LineLeft(); } /// @@ -729,8 +729,8 @@ public void LineLeft() /// public void LineRight() { - //if (scrollViewer != null) - // scrollViewer.LineRight(); + ApplyTemplate(); // ensure scrollViewer is created + ScrollViewer?.LineRight(); } /// @@ -738,8 +738,8 @@ public void LineRight() /// public void LineUp() { - //if (scrollViewer != null) - // scrollViewer.LineUp(); + ApplyTemplate(); // ensure scrollViewer is created + ScrollViewer?.LineUp(); } /// @@ -747,8 +747,8 @@ public void LineUp() /// public void PageDown() { - //if (scrollViewer != null) - // scrollViewer.PageDown(); + ApplyTemplate(); // ensure scrollViewer is created + ScrollViewer?.PageDown(); } /// @@ -756,8 +756,8 @@ public void PageDown() /// public void PageUp() { - //if (scrollViewer != null) - // scrollViewer.PageUp(); + ApplyTemplate(); // ensure scrollViewer is created + ScrollViewer?.PageUp(); } /// @@ -765,8 +765,8 @@ public void PageUp() /// public void PageLeft() { - //if (scrollViewer != null) - // scrollViewer.PageLeft(); + ApplyTemplate(); // ensure scrollViewer is created + ScrollViewer?.PageLeft(); } /// @@ -774,8 +774,8 @@ public void PageLeft() /// public void PageRight() { - //if (scrollViewer != null) - // scrollViewer.PageRight(); + ApplyTemplate(); // ensure scrollViewer is created + ScrollViewer?.PageRight(); } ///