Skip to content

Remove obsolete ACE client from NoaaClient package #3

Description

@Demosfen

Context

NOAA RTSW JSON feeds (rtsw_mag_1m.json, rtsw_wind_1m.json) now provide unified real-time magnetometer and solar wind plasma data from multiple sources (SOLAR1, ACE, IMAP) with active / source metadata.

The legacy ACE text feeds (ace-magnetometer.txt, ace-swepam.txt) overlap with RTSW rows where source == "ACE". For operational mag/wind use cases, IRtswClient is sufficient.

IAceClient is marked [Obsolete] in favor of IRtswClient (see PR #2 / issue #162 follow-up).

Scope

Remove from Integrations package:

  • IAceClient, AceClient, ACE parsers and response models
  • ACE unit tests, benchmark projects, and embedded samples
  • ACE menu entries in NoaaClientSample
  • AddHttpClient<IAceClient, AceClient>() registration
  • ACE sections in README, release notes, and changelog (add explicit breaking-change entry)

Migration guide

Replace:

var mag = await aceClient.GetMagnetometerDataAsync(ct);
var wind = await aceClient.GetSwepamDataAsync(ct);

With:

var mag = await rtswClient.GetMagnetometerDataAsync(ct);
var wind = await rtswClient.GetSolarWindPlasmaDataAsync(ct);

// Primary NOAA-selected feed
var activeMag = mag.Where(r => r.Active);
var activeWind = wind.Where(r => r.Active);

// ACE-specific rows (if needed)
var aceMag = mag.Where(r => r.Source == "ACE");

Out of scope (separate work)

  • SWeather-core still has its own PreliminaryDataImport/ExternalResources/Ace client — migrate in a dedicated SWeather-core task after this package change ships.

Acceptance criteria

  • IAceClient and ACE namespace removed from public API
  • dotnet build / dotnet test pass
  • Sample app exposes RTSW + KpIndex only
  • CHANGELOG documents breaking removal of ACE client

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions