fix: reuse local path from local-mode Bot API server instead of downloading

Author: wcqqq1214

astrbot/core/platform/sources/telegram/tg_adapter.py

@@ -439,17 +439,22 @@ async def message_handler(
     async def _download_to_temp(self, file_path: str) -> str:
         """Download a Telegram file to a local temp path.
 
-        Telegram's file_path can be a relative path (self-hosted Bot API server
-        or reverse proxy setups), and the generic message components only
-        understand local paths or http(s) URLs. So we always fetch the file
-        ourselves instead of passing file_path straight into the component.
+        On the cloud Bot API (and non-local self-hosted servers), get_file()
+        returns an http(s) URL, which we fetch into a temp file so downstream
+        components get a readable local path. But when the Bot API server runs
+        in local mode, get_file() returns an absolute local path instead; that
+        file already lives on disk, so we return it as-is rather than feeding a
+        local path into download_file() (an aiohttp GET, which cannot resolve
+        it).
 
         Args:
             file_path: The file_path returned by Telegram's getFile API.
 
         Returns:
-            Local absolute path of the downloaded file.
+            Local absolute path of the file.
         """
+        if os.path.isfile(file_path):
+            return file_path
         file_basename = os.path.basename(file_path)
         temp_dir = get_astrbot_temp_path()
         temp_path = os.path.join(temp_dir, f"{uuid.uuid4().hex}_{file_basename}")

tests/test_telegram_adapter.py

@@ -231,9 +231,60 @@ async def test_telegram_video_caption_populates_message_text_and_plain(tmp_path)
     )
 
 
+@pytest.mark.asyncio
+async def test_download_to_temp_returns_local_path_without_downloading(tmp_path):
+    """#9448: a local-mode Bot API server returns an absolute local path, which
+    should be reused as-is instead of being downloaded as a URL."""
+    TelegramPlatformAdapter = _load_telegram_adapter()
+    adapter = TelegramPlatformAdapter(
+        make_platform_config("telegram"),
+        {},
+        asyncio.Queue(),
+    )
+    local_file = tmp_path / "photos" / "file_10.jpg"
+    local_file.parent.mkdir(parents=True)
+    local_file.write_bytes(b"local-bytes")
+    convert_message_globals = adapter._download_to_temp.__func__.__globals__
+    mock_download = AsyncMock()
+
+    with patch.dict(convert_message_globals, {"download_file": mock_download}):
+        result = await adapter._download_to_temp(str(local_file))
+
+    assert result == str(local_file)
+    mock_download.assert_not_awaited()
+
+
+@pytest.mark.asyncio
+async def test_download_to_temp_downloads_remote_url(tmp_path):
+    """A remote URL should still be downloaded to the temp dir, not returned as-is."""
+    TelegramPlatformAdapter = _load_telegram_adapter()
+    adapter = TelegramPlatformAdapter(
+        make_platform_config("telegram"),
+        {},
+        asyncio.Queue(),
+    )
+    url = "https://api.telegram.org/file/bot123/photos/file_10.jpg"
+    convert_message_globals = adapter._download_to_temp.__func__.__globals__
+    mock_download = AsyncMock()
+
+    with patch.dict(
+        convert_message_globals,
+        {
+            "get_astrbot_temp_path": MagicMock(return_value=str(tmp_path)),
+            "download_file": mock_download,
+        },
+    ):
+        result = await adapter._download_to_temp(url)
+
+    assert result.startswith(str(tmp_path))
+    assert result != url
+    mock_download.assert_awaited_once()
+    assert mock_download.await_args.args[0] == url
+
+
 @pytest.mark.asyncio
 async def test_telegram_document_downloads_to_local_temp_path(tmp_path):
-    """#9448: document 组件必须拿到本地路径，而不是原始 Telegram file_path/URL。"""
+    """#9448: the document component must hold a local path, not the raw Telegram file_path/URL."""
     TelegramPlatformAdapter = _load_telegram_adapter()
     adapter = TelegramPlatformAdapter(
         make_platform_config("telegram"),
@@ -269,7 +320,7 @@ async def test_telegram_document_downloads_to_local_temp_path(tmp_path):
 
 @pytest.mark.asyncio
 async def test_telegram_video_downloads_to_local_temp_path(tmp_path):
-    """#9448: video 组件必须拿到本地路径，而不是原始 Telegram file_path/URL。"""
+    """#9448: the video component must hold a local path, not the raw Telegram file_path/URL."""
     TelegramPlatformAdapter = _load_telegram_adapter()
     adapter = TelegramPlatformAdapter(
         make_platform_config("telegram"),
@@ -300,7 +351,7 @@ async def test_telegram_video_downloads_to_local_temp_path(tmp_path):
 
 @pytest.mark.asyncio
 async def test_telegram_photo_downloads_to_local_temp_path(tmp_path):
-    """#9448: photo 组件必须拿到本地路径，而不是原始 Telegram file_path/URL。"""
+    """#9448: the photo component must hold a local path, not the raw Telegram file_path/URL."""
     TelegramPlatformAdapter = _load_telegram_adapter()
     adapter = TelegramPlatformAdapter(
         make_platform_config("telegram"),
@@ -329,7 +380,7 @@ async def test_telegram_photo_downloads_to_local_temp_path(tmp_path):
 
 @pytest.mark.asyncio
 async def test_telegram_sticker_downloads_to_local_temp_path(tmp_path):
-    """#9448: sticker 组件必须拿到本地路径，而不是原始 Telegram file_path/URL。"""
+    """#9448: the sticker component must hold a local path, not the raw Telegram file_path/URL."""
     TelegramPlatformAdapter = _load_telegram_adapter()
     adapter = TelegramPlatformAdapter(
         make_platform_config("telegram"),