Skip to content

Commit 0e4fdab

Browse files
committed
fix: address provider icon review feedback
1 parent 582630f commit 0e4fdab

6 files changed

Lines changed: 22 additions & 16 deletions

File tree

dashboard/src/components/provider/AddNewProvider.vue

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -233,10 +233,6 @@ export default {
233233
object-fit: contain;
234234
}
235235
236-
:global(.v-theme--PurpleThemeDark .provider-icon--monochrome) {
237-
filter: brightness(0) invert(1);
238-
}
239-
240236
.provider-logo-fallback {
241237
width: 50px;
242238
height: 50px;

dashboard/src/components/provider/ProviderChatCompletionPanel.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
:available-source-types="availableSourceTypes"
1212
:tm="tm"
1313
:resolve-source-icon="resolveSourceIcon"
14+
:is-monochrome-source-icon="isMonochromeSourceIcon"
1415
:get-source-display-name="getSourceDisplayName"
1516
@add-provider-source="addProviderSource"
1617
@select-provider-source="selectProviderSource"
@@ -230,6 +231,7 @@ const {
230231
advancedSourceConfig,
231232
manualProviderId,
232233
resolveSourceIcon,
234+
isMonochromeSourceIcon,
233235
getSourceDisplayName,
234236
supportsImageInput,
235237
supportsAudioInput,

dashboard/src/components/provider/ProviderSourcesPanel.vue

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -346,10 +346,6 @@ const selectSourceByValue = (value) => {
346346
background: transparent !important;
347347
}
348348
349-
:global(.v-theme--PurpleThemeDark .provider-icon--monochrome) {
350-
filter: brightness(0) invert(1);
351-
}
352-
353349
.provider-source-item__content {
354350
min-width: 0;
355351
flex: 1;

dashboard/src/components/shared/ItemCard.vue

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,4 @@ export default {
176176
background-color: #4caf50;
177177
}
178178
179-
:global(.v-theme--PurpleThemeDark .provider-icon--monochrome) {
180-
filter: brightness(0) invert(1);
181-
}
182179
</style>

dashboard/src/composables/useProviderSources.ts

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,17 @@ export interface UseProviderSourcesOptions {
1010
showMessage: (message: string, color?: string) => void
1111
}
1212

13+
interface ProviderSourceType {
14+
value: string
15+
label: string
16+
icon: string
17+
isMonochrome: boolean
18+
}
19+
20+
interface ProviderIconSource {
21+
provider?: string
22+
}
23+
1324
export function resolveDefaultTab(value?: string) {
1425
const normalized = (value || '').toLowerCase()
1526

@@ -84,7 +95,7 @@ export function useProviderSources(options: UseProviderSourcesOptions) {
8495
return []
8596
}
8697

87-
const types: Array<{ value: string; label: string; icon: string; isMonochrome: boolean }> = []
98+
const types: ProviderSourceType[] = []
8899
for (const [templateName, template] of Object.entries(providerTemplates.value)) {
89100
if (template.provider_type === selectedProviderType.value) {
90101
types.push({
@@ -292,13 +303,13 @@ export function useProviderSources(options: UseProviderSourcesOptions) {
292303
return type.includes(providerType)
293304
}
294305

295-
function resolveSourceIcon(source: any) {
306+
function resolveSourceIcon(source: ProviderIconSource | null | undefined) {
296307
if (!source) return ''
297-
return getProviderIcon(source.provider) || ''
308+
return getProviderIcon(source.provider || '') || ''
298309
}
299310

300-
function isMonochromeSourceIcon(source: any) {
301-
return Boolean(source && isMonochromeProviderIcon(source.provider))
311+
function isMonochromeSourceIcon(source: ProviderIconSource | null | undefined) {
312+
return Boolean(source && isMonochromeProviderIcon(source.provider || ''))
302313
}
303314

304315
function getSourceDisplayName(source: any) {

dashboard/src/scss/_override.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,3 +130,7 @@ pre, code, .markdown pre, .markdown code, .release-notes pre, .release-notes cod
130130
color: rgb(var(--v-theme-primary));
131131
}
132132
}
133+
134+
.v-theme--PurpleThemeDark .provider-icon--monochrome {
135+
filter: brightness(0) invert(1);
136+
}

0 commit comments

Comments
 (0)