test(speak): kill mutation survivors (Segment frozen, multi --out path); fix dialogue test typing

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: alexkroman-assembly

tests/test_speak.py

@@ -195,6 +195,18 @@ def test_dialogue_json_reports_speaker_voice_map(fake_dialogue):
     assert payload["audio_duration_seconds"] == 1.235
 
 
+def test_dialogue_json_out_path_is_reported(fake_dialogue, monkeypatch, tmp_path):
+    # With --out, the multi JSON reports the file path (not null) — pins the
+    # `str(out) if out is not None else None` branch in _emit_multi.
+    monkeypatch.setattr("aai_cli.commands.speak.audio.write_wav", lambda *a, **k: None)
+    out = tmp_path / "dialogue.wav"
+    text = "Speaker A: One.\nSpeaker B: Two."
+    result = runner.invoke(app, ["--sandbox", "speak", "--out", str(out), "--json"], input=text)
+    assert result.exit_code == 0
+    payload = json.loads(result.stdout.strip())
+    assert payload["out"] == str(out)
+
+
 def test_empty_speaker_labels_raises_usage_error():
     # Speaker-labeled input with no spoken text: detected as labeled, parses to zero
     # segments, and raises the usage error before any synthesis.

tests/test_tts_dialogue.py

@@ -19,6 +19,13 @@ def test_plain_prose_is_not_labeled():
     assert dialogue.looks_like_speaker_labeled("") is False
 
 
+def test_segment_is_immutable():
+    seg = dialogue.Segment("A", "hi")
+    attr = "text"  # a variable (not a constant) keeps ruff's B010 from rewriting setattr
+    with pytest.raises(AttributeError):  # frozen=True -> assignment is blocked
+        setattr(seg, attr, "changed")
+
+
 def test_parse_single_line_turns():
     segs = dialogue.parse_segments("Speaker A: Hello.\nSpeaker B: Hi there.")
     assert [(s.speaker_id, s.text) for s in segs] == [("A", "Hello."), ("B", "Hi there.")]

tests/test_tts_session.py

@@ -311,9 +311,9 @@ def test_synthesize_dialogue_uses_server_sample_rate():
 
 
 def test_synthesize_dialogue_empty_segments_returns_silent_default():
-    # No segments -> no audio at the default rate, and no crash (the connect factory
-    # is never invoked because the loop body never runs).
-    result = session.synthesize_dialogue("k", [], connect=lambda *a, **k: None)
+    # No segments -> no audio at the default rate, and no crash. connect is omitted
+    # entirely: the loop body never runs, so no connection is ever attempted.
+    result = session.synthesize_dialogue("k", [])
     assert result.pcm == b""
     assert result.sample_rate == 24000
     assert result.audio_duration_seconds == 0.0