Skip to content

Commit b0616b3

Browse files
committed
Idiomatic package tidy-ups: empty grouping __init__, _-prefixed test helpers
- Empty the four layer/grouping __init__.py (core, ui, app, app/transcribe) to match the agent/tts/streaming precedent — a no-op `from __future__` import in an otherwise-empty package init isn't meaningful. - Rename tests/setup_helpers.py -> _setup_helpers.py and tests/replay_fixtures.py -> _replay_fixtures.py so every non-test support module in tests/ shares the underscore-prefix convention (pytest won't collect them as test modules); update the three importers and the two doc references. No behavior change.
1 parent dc82d65 commit b0616b3

10 files changed

Lines changed: 11 additions & 9 deletions

File tree

aai_cli/app/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
from __future__ import annotations

aai_cli/app/transcribe/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
from __future__ import annotations

aai_cli/core/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
from __future__ import annotations

aai_cli/ui/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
from __future__ import annotations

tests/AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ these live in the default suite. Three moving parts:
102102
Refresh after an API shape change: `ASSEMBLYAI_API_KEY=… uv run python scripts/record_fixtures.py`.
103103
The key comes from the env; the AMS session JWT + `account_id` from the keyring/`config.toml`
104104
of whoever ran `assembly login` (profile `default`) — neither is ever written to a fixture.
105-
- **`tests/replay_fixtures.py`** — rebuilds the boundary objects from JSON. A transcript is a
105+
- **`tests/_replay_fixtures.py`** — rebuilds the boundary objects from JSON. A transcript is a
106106
real `aai.Transcript` via `Transcript.from_response`; an LLM response is rebuilt with
107107
`ChatCompletion.model_construct` (**not** `model_validate`) because the gateway returns
108108
Anthropic-flavored fields — `finish_reason="end_turn"`, token counts under

tests/test_replay_e2e.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""End-to-end replay tests: drive real CLI commands against recorded API responses.
22
33
Each test patches the command's network boundary (``client.* / llm.* / ams.*``) to
4-
return an object rebuilt from a real, scrubbed fixture (see ``tests/replay_fixtures.py``
4+
return an object rebuilt from a real, scrubbed fixture (see ``tests/_replay_fixtures.py``
55
and ``scripts/record_fixtures.py``), then invokes the command through Typer and asserts
66
on the rendered output. The transport stays offline — pytest-socket is untouched — but
77
the command's own parsing, formatting, and rendering all run against a real payload.
@@ -13,7 +13,7 @@
1313

1414
from aai_cli.core import config
1515
from aai_cli.main import app
16-
from tests import replay_fixtures as rf
16+
from tests import _replay_fixtures as rf
1717

1818
runner = CliRunner()
1919

tests/test_setup.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,13 @@
55
from typer.testing import CliRunner
66

77
from aai_cli.main import app
8-
from tests.setup_helpers import FakeRun, _all_tools_present, _cli_skill_path, _skill_path, _statuses
8+
from tests._setup_helpers import (
9+
FakeRun,
10+
_all_tools_present,
11+
_cli_skill_path,
12+
_skill_path,
13+
_statuses,
14+
)
915

1016
runner = CliRunner()
1117

tests/test_setup_install.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from typer.testing import CliRunner
66

77
from aai_cli.main import app
8-
from tests.setup_helpers import (
8+
from tests._setup_helpers import (
99
FakeRun,
1010
_all_tools_present,
1111
_cli_skill_path,

0 commit comments

Comments
 (0)