Skip to content

Commit c0d227f

Browse files
alexkromanalexkroman-assemblyclaude
authored
chore: remove the pre-push git hook (#4)
Drop .githooks/pre-push (and its installer scripts/install-hooks.sh). The hook ran the full scripts/check.sh on every push, which also triggered `xcodegen generate` and clobbered the committed Package.resolved. CI (the required `check` status) already gates main, so the local hook is redundant. Also strips the now-dead install-hooks references from AGENTS.md, CONTRIBUTING.md, and the check.sh shellcheck comment. Co-authored-by: Alex Kroman <alex@assemblyai.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 57ad5fa commit c0d227f

5 files changed

Lines changed: 2 additions & 64 deletions

File tree

.githooks/pre-push

Lines changed: 0 additions & 45 deletions
This file was deleted.

AGENTS.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ swift test --filter DictationSessionTests # single suite
2020
swift test --filter happyPath # single test case by name
2121

2222
scripts/check.sh # full health check (see below) — same script CI runs
23-
scripts/install-hooks.sh # one-time: point core.hooksPath at .githooks/ (pre-commit runs check.sh)
2423
scripts/dev-build.sh # signed Debug build + install to /Applications (local dev)
2524
```
2625

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ you don't reintroduce something that was deliberately removed.
1919

2020
```bash
2121
scripts/bootstrap.sh # install the local toolchain on a fresh Mac
22-
scripts/install-hooks.sh # one-time: point core.hooksPath at .githooks/ (pre-commit runs check.sh)
2322
scripts/dev-build.sh # signed Debug build + install to /Applications
2423
swift test # engine unit tests (Swift Testing)
2524
scripts/check.sh # full health check — the same script CI runs

scripts/check.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,8 @@ fi
223223
if command -v shellcheck >/dev/null 2>&1; then
224224
echo "==> shellcheck"
225225
cd "$REPO_ROOT"
226-
# Static analysis for the project's shell scripts (release-*, install-hooks,
227-
# check.sh itself) — catches quoting bugs, unset vars, and unsafe patterns.
226+
# Static analysis for the project's shell scripts (release-*, check.sh
227+
# itself) — catches quoting bugs, unset vars, and unsafe patterns.
228228
shellcheck scripts/*.sh
229229
else
230230
echo "note: shellcheck not installed; skipping (brew install shellcheck)"

scripts/install-hooks.sh

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)