Skip to content

Bug: WebHost displays OptionList (with valid_keys) options as checkboxes #6353

Description

@Mysteryem

What happened?

OptionList options allow duplicate elements and the order of the elements within the list may have some importance to the option.

WebHost currently displays OptionList options (with valid_keys defined) using checkboxes, which are not suitable for either specifying duplicate elements, or setting a specific order of the elements.

I think every OptionList option that is currently displayed on the archipelago.gg WebHost should instead be implemented as an OptionSet, so while the checkboxes look correct for these options, the options themselves are using the wrong option type.

Here is how an OptionList currently displays on WebHost:
Image

What were the expected results?

OptionList type options on WebHost should allow for duplicate elements, as well as maintaining a well-defined order of the elements within the list.

For example, Dexsanity Encounter Types in Pokemon Emerald (which should have been implemented as OptionSet, but was instead implemented as an OptionList) on the ionium yaml editor (https://ap-lobby.ionium.us/options/pokemon_emerald) allows for elements to be added individually, including duplicates, and maintaining order.

Image Producing a yaml with:
  dexsanity_encounter_types:
    - Land
    - Land
    - Fishing
    - Water
    - Land

Ideally, the editor for an OptionList option would also make it easy to reorder elements, but this is not a hard requirement.

Software

Website

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions