Syntax Highlighting on Code

[AndrewHenderson]

http://codemirror.net/mode/css/index.html

[mohsen1]

Should we use it?

On Sun, Dec 4, 2011 at 5:13 PM, Andrew Henderson <
reply@reply.github.com

wrote:

http://codemirror.net/mode/css/index.html

---

Reply to this email directly or view it on GitHub:
https://github.com/ahendy/css3patternz/issues/12

Mohsen Nabiloo Azimi

[AndrewHenderson]

It looks pretty good. I'd like to try it. My only concern is when users edit the code within the code area.

I imagine it will be hard to not only render the adjusted code within the pattern, but update all of the tools within the control panel. We may want to do away with allowing users to edit within the code area. If we do want to allow users to edit the pattern within the code area (or import code by copying from another source and just dropping it in the code area) things to think about:

1. If they change a HEX color in the code area from #777777 to #CC0000, will the layer strip be updated within the inspectrum?

2. What happens if they edit the various prefixes differently? On -webkit they change a strip color to blue, -moz they change it to green, and on W3C they change it to red. Which does the pattern reflect? Which does the inpsectrum reflect?

3. If they can drop code in the code area from another source, how will the aside create individual layers and strips within their respective inspectrums?

[mohsen1]

For now we will disable tools after first change happened in editor but in
future I will write a code parser that translate edited code to our pattern
object standard format. You should take care about disabling tools area
after code is edited.

I commited code editor. Go ahead and look at it. It allow user to edit the
code and see the changes right there. If you want to do something write a
function under ui that disables editor with overlaying all the sidebar with
white or black transparent color and saying "you changed the code and can
not use tools anymore. to continue with tools undo your changes:
undo(link)". This function should called at main.js line 300. The link
should call ui.render().

On Sun, Dec 4, 2011 at 7:33 PM, Andrew Henderson <
reply@reply.github.com

wrote:

It looks pretty good. I'd like to try it. My only concern is when users
edit the code within the code area.

I imagine it will be hard to not only render the adjusted code within the
pattern, but update all of the tools within the control panel. We may want
to do away with allowing users to edit within the code area. If we do want
to allow users to edit the pattern within the code area (or import code by
copying from another source and just dropping it in the code area) things
to think about:

1. If they change a HEX color in the code area from #777777 to #CC0000,
   will the layer strip be updated within the inspectrum?

2. What happens if they edit the various prefixes differently? On -webkit
   they change a strip color to blue, -moz they change it to green, and on W3C
   they change it to red. Which does the pattern reflect? Which does the
   inpsectrum reflect?

3. If they can drop code in the code area from another source, how with
   the aside create individual layers and strips within their respective
   inspectrums?

---

Reply to this email directly or view it on GitHub:
https://github.com/ahendy/css3patternz/issues/12#issuecomment-3010962

Mohsen Nabiloo Azimi

[AndrewHenderson]

That looks great. Way better given how it breaks up the background image
codes in separate blocks.

On Sun, Dec 4, 2011 at 7:42 PM, Mohsen <
reply@reply.github.com

wrote:

For now we will disable tools after first change happened in editor but in
future I will write a code parser that translate edited code to our pattern
object standard format. You should take care about disabling tools area
after code is edited.

I commited code editor. Go ahead and look at it. It allow user to edit the
code and see the changes right there. If you want to do something write a
function under ui that disables editor with overlaying all the sidebar with
white or black transparent color and saying "you changed the code and can
not use tools anymore. to continue with tools undo your changes:
undo(link)". This function should called at main.js line 300. The link
should call ui.render().

On Sun, Dec 4, 2011 at 7:33 PM, Andrew Henderson <
reply@reply.github.com

wrote:

It looks pretty good. I'd like to try it. My only concern is when users
edit the code within the code area.

I imagine it will be hard to not only render the adjusted code within the
pattern, but update all of the tools within the control panel. We may
want
to do away with allowing users to edit within the code area. If we do
want
to allow users to edit the pattern within the code area (or import code
by
copying from another source and just dropping it in the code area) things
to think about:

1. If they change a HEX color in the code area from #777777 to #CC0000,
   will the layer strip be updated within the inspectrum?

2. What happens if they edit the various prefixes differently? On -webkit
   they change a strip color to blue, -moz they change it to green, and on
   W3C
   they change it to red. Which does the pattern reflect? Which does the
   inpsectrum reflect?

3. If they can drop code in the code area from another source, how with
   the aside create individual layers and strips within their respective
   inspectrums?

---

Reply to this email directly or view it on GitHub:
https://github.com/ahendy/css3patternz/issues/12#issuecomment-3010962

Mohsen Nabiloo Azimi

---

Reply to this email directly or view it on GitHub:
https://github.com/ahendy/css3patternz/issues/12#issuecomment-3011014

Andrew Henderson
Projects http://andrewhenderson.me |
LinkedInhttp://www.linkedin.com/in/andrewmhenderson|
Facebook http://facebook.com/andrew.m.henderson |
Twitterhttp://twitter.com/AndrewHenderson