ci: merge coverage into one report; fix Api assembly exclusion

Author: g9shubh

DocAnalytics.Api/Program.cs

@@ -1,4 +1,3 @@
-using System.Diagnostics.CodeAnalysis;
 using System.Text.Json;
 using System.Threading.RateLimiting;
 using DocAnalytics.Api.Auth;      // JwtSettings
@@ -19,7 +18,6 @@
 using DocAnalytics.Service.Realtime;
 using Microsoft.Extensions.Options;
 
-[assembly: ExcludeFromCodeCoverage]
 
 
 var builder = WebApplication.CreateBuilder(args);

scripts/coverage-gate.sh

@@ -8,7 +8,7 @@ FLOOR_API=22
 
 ROOT="$(pwd)"
 OUT="$ROOT/coverage-out"
-mkdir -p "$OUT"
+rm -rf "$OUT"; mkdir -p "$OUT"
 
 echo "== Restore local tools (ReportGenerator) =="
 dotnet tool restore
@@ -21,69 +21,48 @@ run_test () {
     --configuration Release \
     --collect:"XPlat Code Coverage" \
     --settings coverage.runsettings \
-    --results-directory "$dir" \
-    --logger "trx;LogFileName=$name.trx"
+    --results-directory "$dir"
 }
 
 run_test "DocAnalytics.Domain.Tests/DocAnalytics.Domain.Tests.csproj"   "domain"
 run_test "DocAnalytics.Data.Tests/DocAnalytics.Data.Tests.csproj"       "data"
 run_test "DocAnalytics.Service.Tests/DocAnalytics.Service.Tests.csproj" "service"
 run_test "DocAnalytics.Api.Tests/DocAnalytics.Api.Tests.csproj"         "api"
 
-find_cobertura () { find "$OUT/$1" -type f -name "coverage.cobertura.xml" | head -n 1; }
+mapfile -t COBS < <(find "$OUT" -type f -name "coverage.cobertura.xml")
+if [[ ${#COBS[@]} -eq 0 ]]; then
+  echo "ERROR: no cobertura files found"; exit 2
+fi
+REPORTS=$(IFS=';'; echo "${COBS[*]}")
+echo "== Merging ${#COBS[@]} coverage files into one report =="
 
-gen_summary () {
-  local name="$1"; local cobertura="$2"; local target="$OUT/summary-$name"
-  mkdir -p "$target"
-  dotnet reportgenerator \
-    "-reports:$cobertura" \
-    "-targetdir:$target" \
-    "-reporttypes:JsonSummary" \
-    "-verbosity:Error" >/dev/null
-}
-
-for layer in domain data service api; do
-  cov="$(find_cobertura "$layer")"
-  if [[ -z "${cov:-}" ]]; then
-    echo "ERROR: no coverage.cobertura.xml for $layer"; exit 2
-  fi
-  gen_summary "$layer" "$cov"
-done
+dotnet reportgenerator \
+  "-reports:$REPORTS" \
+  "-targetdir:$OUT/summary" \
+  "-reporttypes:JsonSummary" \
+  "-verbosity:Error" >/dev/null
 
 echo "== Coverage gate (per-assembly line %) =="
-python3 - "$OUT" "$FLOOR_SERVICE" "$FLOOR_DOMAIN" "$FLOOR_DATA" "$FLOOR_API" <<'PY'
-import json, os, sys
-out = sys.argv[1]
-targets = {
-    "service": ("DocAnalytics.Service", float(sys.argv[2])),
-    "domain":  ("DocAnalytics.Domain",  float(sys.argv[3])),
-    "data":    ("DocAnalytics.Data",    float(sys.argv[4])),
-    "api":     ("DocAnalytics.Api",     float(sys.argv[5])),
+python3 - "$OUT/summary/Summary.json" "$FLOOR_SERVICE" "$FLOOR_DOMAIN" "$FLOOR_DATA" "$FLOOR_API" <<'PY'
+import json, sys
+with open(sys.argv[1]) as f:
+    doc = json.load(f)
+floors = {
+    "DocAnalytics.Service": float(sys.argv[2]),
+    "DocAnalytics.Domain":  float(sys.argv[3]),
+    "DocAnalytics.Data":    float(sys.argv[4]),
+    "DocAnalytics.Api":     float(sys.argv[5]),
 }
-
-def asm_cov(report_name, asm_name):
-    p = os.path.join(out, f"summary-{report_name}", "Summary.json")
-    with open(p) as f:
-        doc = json.load(f)
-    for a in doc.get("coverage", {}).get("assemblies", []):
-        if a.get("name") == asm_name:
-            if a.get("coverage") is not None:
-                return float(a["coverage"])
-            cl = a.get("coveredlines", 0); cov = a.get("coverablelines", 0)
-            return (100.0 * cl / cov) if cov else 0.0
-    return None
-
+asms = { a["name"]: a for a in doc.get("coverage", {}).get("assemblies", []) }
 fail = False
-for rep, (asm, floor) in targets.items():
-    lc = asm_cov(rep, asm)
-    if lc is None:
-        print(f"{rep:8} assembly {asm} NOT FOUND -> FAIL")
-        fail = True
-        continue
+for name, floor in floors.items():
+    a = asms.get(name)
+    if a is None:
+        print(f"{name:22} NOT FOUND -> FAIL"); fail = True; continue
+    lc = float(a["coverage"]) if a.get("coverage") is not None else \
+         (100.0 * a.get("coveredlines", 0) / a["coverablelines"] if a.get("coverablelines") else 0.0)
     ok = lc + 1e-9 >= floor
-    if not ok:
-        fail = True
-    print(f"{rep:8} {asm:22} line={lc:6.2f}  floor={floor:5.1f}  -> {'OK' if ok else 'FAIL'}")
+    if not ok: fail = True
+    print(f"{name:22} line={lc:6.2f}  floor={floor:5.1f}  -> {'OK' if ok else 'FAIL'}")
 sys.exit(1 if fail else 0)
 PY
-