[Bug]: Using deprecated function in PHP 8.5

[HowardHow]

Description

Using deprecated curl_close function in PHP 8.5

Steps to reproduce

1. Install Magento2
2. Install adyen/module-payment and it automatically requires this library with version 28
3. Setup payment configurations
4. When proceed to payment stage, it showed the deprecated functionality error

Actual behavior

It showed this error
Deprecated Functionality: Function curl_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in vendor/adyen/php-api-library/src/Adyen/HttpClient/CurlClient.php on line 356

Expected behavior

It should proceed the checkout flow without issue

Code snippet or screenshots (if applicable)

vendor/adyen/php-api-library/src/Adyen/HttpClient/CurlClient.php line 150 and 356

// requestPost method in line 150
// Execute the request
[$result, $httpStatus] = $this->curlRequest($ch);

// Get errors
[$errno] = $this->curlError($ch);

curl_close($ch);

$resultOKHttpStatusCodes = array(200, 201, 202, 204);

// requestHttp method in line 356
// Execute the request
[$result, $httpStatus] = $this->curlRequest($ch);

// Get errors
[$errno] = $this->curlError($ch);

curl_close($ch);

$hasFailed = !in_array($httpStatus, array(200, 201, 202, 204));

Adyen PHP API Library version

v28.3.0

PHP version

8.5

Operating System

Linux

Additional context

No response

[jeandersonbc]

Hi @HowardHow,

We have a fix to be merged (#921), including PHP 8.5 in our CI pipelines.
We also have a branch to enable the conversion of deprecations into errors in phpunit (convertDeprecationsToExceptions="true") to prevent these issues in the future.

We will keep you posted about a patch-release. Thank you for raising, this up!

[andrej-gajduk-adyen]

Hi @HowardHow

We released a patch to fix this issue: https://github.com/Adyen/adyen-php-api-library/releases/tag/v28.3.1

Please let us know if this produced the expected behavior on your end.

[jeandersonbc]

Closing this as the issue has been fixed and the is no activity on this issue. Feel free to create a new one in the future if needed.