Skip to content

Commit 38823ef

Browse files
jeandersonbcjeandersonbc
committed
chore(deps): cleanup and standardized pom.xml
- removed unused coveralls plugin - moved plugin and dep versions to properties - grouped depdencies (and versions) per scope - remove redundant maven dependency scope
1 parent ff7a75d commit 38823ef

1 file changed

Lines changed: 92 additions & 81 deletions

File tree

‎pom.xml‎

Lines changed: 92 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,45 @@
2323
</developer>
2424
</developers>
2525
<properties>
26+
<!-- Project Settings -->
2627
<maven.compiler.source>11</maven.compiler.source>
2728
<maven.compiler.target>11</maven.compiler.target>
28-
2929
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
3030
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
31-
<swagger-core-version>1.6.16</swagger-core-version>
3231
<sonar.organization>adyen</sonar.organization>
3332
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
33+
34+
<!-- Dependency Versions -->
35+
<!-- Compile -->
36+
<com.fasterxml.jackson-version>2.21.0</com.fasterxml.jackson-version>
37+
<gson-version>2.11.0</gson-version>
38+
<commons-codec-version>1.18.0</commons-codec-version>
39+
<gson-fire-version>1.9.0</gson-fire-version>
40+
<swagger-core-version>1.6.16</swagger-core-version>
41+
<swagger-annotations-v3-version>2.2.30</swagger-annotations-v3-version>
42+
<jakarta.ws.rs-api-version>3.1.0</jakarta.ws.rs-api-version>
43+
<jaxb-api-version>2.3.1</jaxb-api-version>
44+
<httpclient5-version>5.5</httpclient5-version>
45+
46+
<!-- Test -->
47+
<okio-version>3.16.4</okio-version>
48+
<hamcrest-version>3.0</hamcrest-version>
3449
<junit-jupiter-version>5.11.4</junit-jupiter-version>
3550
<mockito-version>5.21.0</mockito-version>
51+
52+
<!-- Plugin Versions -->
53+
<maven-compiler-plugin-version>3.14.1</maven-compiler-plugin-version>
54+
<maven-jar-plugin-version>3.5.0</maven-jar-plugin-version>
55+
<jacoco-maven-plugin-version>0.8.14</jacoco-maven-plugin-version>
56+
<maven-source-plugin-version>3.3.1</maven-source-plugin-version>
57+
<maven-javadoc-plugin-version>3.12.0</maven-javadoc-plugin-version>
58+
<maven-gpg-plugin-version>3.2.8</maven-gpg-plugin-version>
59+
<central-publishing-maven-plugin-version>0.7.0</central-publishing-maven-plugin-version>
60+
<maven-checkstyle-plugin-version>3.6.0</maven-checkstyle-plugin-version>
61+
<maven-bundle-plugin-version>5.1.9</maven-bundle-plugin-version>
62+
<spotless-maven-plugin-version>3.2.1</spotless-maven-plugin-version>
63+
<maven-surefire-plugin-version>3.5.2</maven-surefire-plugin-version>
64+
<google-java-format-version>1.34.1</google-java-format-version>
3665
</properties>
3766
<scm>
3867
<connection>scm:git:git@github.com:Adyen/adyen-java-api-library.git</connection>
@@ -44,34 +73,22 @@
4473
<plugin>
4574
<groupId>org.apache.maven.plugins</groupId>
4675
<artifactId>maven-compiler-plugin</artifactId>
47-
<version>3.14.1</version>
76+
<version>${maven-compiler-plugin-version}</version>
4877
</plugin>
4978
<plugin>
5079
<groupId>org.apache.maven.plugins</groupId>
5180
<artifactId>maven-jar-plugin</artifactId>
52-
<version>3.5.0</version>
81+
<version>${maven-jar-plugin-version}</version>
5382
<configuration>
5483
<archive>
5584
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
5685
</archive>
5786
</configuration>
5887
</plugin>
59-
<plugin>
60-
<groupId>org.eluder.coveralls</groupId>
61-
<artifactId>coveralls-maven-plugin</artifactId>
62-
<version>4.3.0</version>
63-
<dependencies>
64-
<dependency>
65-
<groupId>javax.xml.bind</groupId>
66-
<artifactId>jaxb-api</artifactId>
67-
<version>2.3.1</version>
68-
</dependency>
69-
</dependencies>
70-
</plugin>
7188
<plugin>
7289
<groupId>org.jacoco</groupId>
7390
<artifactId>jacoco-maven-plugin</artifactId>
74-
<version>0.8.14</version>
91+
<version>${jacoco-maven-plugin-version}</version>
7592
<executions>
7693
<execution>
7794
<id>prepare-agent</id>
@@ -95,7 +112,7 @@
95112
<plugin>
96113
<groupId>org.apache.maven.plugins</groupId>
97114
<artifactId>maven-source-plugin</artifactId>
98-
<version>3.3.1</version>
115+
<version>${maven-source-plugin-version}</version>
99116
<executions>
100117
<execution>
101118
<id>attach-sources</id>
@@ -108,7 +125,7 @@
108125
<plugin>
109126
<groupId>org.apache.maven.plugins</groupId>
110127
<artifactId>maven-javadoc-plugin</artifactId>
111-
<version>3.12.0</version>
128+
<version>${maven-javadoc-plugin-version}</version>
112129
<executions>
113130
<execution>
114131
<id>attach-javadocs</id>
@@ -121,7 +138,7 @@
121138
<plugin>
122139
<groupId>org.apache.maven.plugins</groupId>
123140
<artifactId>maven-gpg-plugin</artifactId>
124-
<version>3.2.8</version>
141+
<version>${maven-gpg-plugin-version}</version>
125142
<executions>
126143
<execution>
127144
<id>sign-artifacts</id>
@@ -136,7 +153,7 @@
136153
<plugin>
137154
<groupId>org.sonatype.central</groupId>
138155
<artifactId>central-publishing-maven-plugin</artifactId>
139-
<version>0.7.0</version>
156+
<version>${central-publishing-maven-plugin-version}</version>
140157
<extensions>true</extensions>
141158
<configuration>
142159
<publishingServerId>central</publishingServerId>
@@ -149,7 +166,7 @@
149166
<plugin>
150167
<groupId>org.apache.maven.plugins</groupId>
151168
<artifactId>maven-checkstyle-plugin</artifactId>
152-
<version>3.6.0</version>
169+
<version>${maven-checkstyle-plugin-version}</version>
153170
<configuration>
154171
<configLocation>checkstyle.xml</configLocation>
155172
<suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
@@ -169,7 +186,7 @@
169186
<plugin>
170187
<groupId>org.apache.felix</groupId>
171188
<artifactId>maven-bundle-plugin</artifactId>
172-
<version>5.1.9</version>
189+
<version>${maven-bundle-plugin-version}</version>
173190
<executions>
174191
<execution>
175192
<id>bundle-manifest</id>
@@ -189,7 +206,7 @@
189206
<plugin>
190207
<groupId>com.diffplug.spotless</groupId>
191208
<artifactId>spotless-maven-plugin</artifactId>
192-
<version>3.2.1</version>
209+
<version>${spotless-maven-plugin-version}</version>
193210
<executions>
194211
<execution>
195212
<goals>
@@ -204,11 +221,11 @@
204221
<include>src/test/java/**/*.java</include>
205222
</includes>
206223
<googleJavaFormat>
207-
<version>1.34.1</version>
224+
<version>${google-java-format-version}</version>
208225
<style>GOOGLE</style>
209226
<formatJavadoc>true</formatJavadoc>
210227
</googleJavaFormat>
211-
<importOrder /> <!-- standard import order -->
228+
<importOrder/> <!-- standard import order -->
212229
<removeUnusedImports>
213230
<engine>google-java-format</engine>
214231
</removeUnusedImports>
@@ -218,100 +235,94 @@
218235
<plugin>
219236
<groupId>org.apache.maven.plugins</groupId>
220237
<artifactId>maven-surefire-plugin</artifactId>
221-
<version>3.5.2</version>
238+
<version>${maven-surefire-plugin-version}</version>
222239
</plugin>
223240

224241
</plugins>
225242
</build>
226243
<dependencies>
227-
<dependency>
228-
<groupId>com.fasterxml.jackson.datatype</groupId>
229-
<artifactId>jackson-datatype-jsr310</artifactId>
230-
<version>2.21.0</version>
231-
</dependency>
244+
<!-- Compile -->
232245
<dependency>
233246
<groupId>com.fasterxml.jackson.core</groupId>
234247
<artifactId>jackson-databind</artifactId>
235-
<version>2.21.0</version>
248+
<version>${com.fasterxml.jackson-version}</version>
249+
</dependency>
250+
<dependency>
251+
<groupId>com.fasterxml.jackson.datatype</groupId>
252+
<artifactId>jackson-datatype-jsr310</artifactId>
253+
<version>${com.fasterxml.jackson-version}</version>
236254
</dependency>
237255
<dependency>
238256
<groupId>com.google.code.gson</groupId>
239257
<artifactId>gson</artifactId>
240-
<version>2.11.0</version>
241-
<scope>compile</scope>
258+
<version>${gson-version}</version>
242259
</dependency>
243260
<dependency>
244-
<groupId>org.apache.httpcomponents.client5</groupId>
245-
<artifactId>httpclient5</artifactId>
246-
<version>5.5</version>
247-
<scope>compile</scope>
261+
<groupId>commons-codec</groupId>
262+
<artifactId>commons-codec</artifactId>
263+
<version>${commons-codec-version}</version>
248264
</dependency>
249-
250265
<dependency>
251-
<groupId>org.junit.jupiter</groupId>
252-
<artifactId>junit-jupiter</artifactId>
253-
<version>${junit-jupiter-version}</version>
254-
<scope>test</scope>
266+
<groupId>io.gsonfire</groupId>
267+
<artifactId>gson-fire</artifactId>
268+
<version>${gson-fire-version}</version>
255269
</dependency>
256270
<dependency>
257-
<groupId>org.mockito</groupId>
258-
<artifactId>mockito-junit-jupiter</artifactId>
259-
<version>${mockito-version}</version>
260-
<scope>test</scope>
271+
<groupId>io.swagger</groupId>
272+
<artifactId>swagger-annotations</artifactId>
273+
<version>${swagger-core-version}</version>
261274
</dependency>
262275
<dependency>
263-
<groupId>org.mockito</groupId>
264-
<artifactId>mockito-core</artifactId>
265-
<version>${mockito-version}</version>
266-
<scope>test</scope>
276+
<groupId>io.swagger.core.v3</groupId>
277+
<artifactId>swagger-annotations</artifactId>
278+
<version>${swagger-annotations-v3-version}</version>
267279
</dependency>
268280
<dependency>
269-
<groupId>org.hamcrest</groupId>
270-
<artifactId>hamcrest</artifactId>
271-
<version>3.0</version>
272-
<scope>test</scope>
281+
<groupId>jakarta.ws.rs</groupId>
282+
<artifactId>jakarta.ws.rs-api</artifactId>
283+
<version>${jakarta.ws.rs-api-version}</version>
273284
</dependency>
274285
<dependency>
275286
<groupId>javax.xml.bind</groupId>
276287
<artifactId>jaxb-api</artifactId>
277-
<version>2.3.1</version>
278-
<scope>compile</scope>
288+
<version>${jaxb-api-version}</version>
279289
</dependency>
280290
<dependency>
281-
<groupId>io.swagger.core.v3</groupId>
282-
<artifactId>swagger-annotations</artifactId>
283-
<version>2.2.30</version>
284-
<scope>compile</scope>
291+
<groupId>org.apache.httpcomponents.client5</groupId>
292+
<artifactId>httpclient5</artifactId>
293+
<version>${httpclient5-version}</version>
285294
</dependency>
295+
296+
<!-- Test -->
286297
<dependency>
287-
<groupId>jakarta.ws.rs</groupId>
288-
<artifactId>jakarta.ws.rs-api</artifactId>
289-
<version>3.1.0</version>
290-
<scope>compile</scope>
298+
<groupId>com.squareup.okio</groupId>
299+
<artifactId>okio</artifactId>
300+
<version>${okio-version}</version>
301+
<scope>test</scope>
291302
</dependency>
292303
<dependency>
293-
<groupId>io.gsonfire</groupId>
294-
<artifactId>gson-fire</artifactId>
295-
<version>1.9.0</version>
296-
<scope>compile</scope>
304+
<groupId>org.hamcrest</groupId>
305+
<artifactId>hamcrest</artifactId>
306+
<version>${hamcrest-version}</version>
307+
<scope>test</scope>
297308
</dependency>
298309
<dependency>
299-
<groupId>com.squareup.okio</groupId>
300-
<artifactId>okio</artifactId>
301-
<version>3.16.4</version>
310+
<groupId>org.junit.jupiter</groupId>
311+
<artifactId>junit-jupiter</artifactId>
312+
<version>${junit-jupiter-version}</version>
302313
<scope>test</scope>
303314
</dependency>
304315
<dependency>
305-
<groupId>commons-codec</groupId>
306-
<artifactId>commons-codec</artifactId>
307-
<version>1.18.0</version> <!-- or the latest version -->
316+
<groupId>org.mockito</groupId>
317+
<artifactId>mockito-core</artifactId>
318+
<version>${mockito-version}</version>
319+
<scope>test</scope>
308320
</dependency>
309-
<!-- Generated model annotations -->
310321
<dependency>
311-
<groupId>io.swagger</groupId>
312-
<artifactId>swagger-annotations</artifactId>
313-
<version>${swagger-core-version}</version>
314-
<scope>compile</scope>
322+
<groupId>org.mockito</groupId>
323+
<artifactId>mockito-junit-jupiter</artifactId>
324+
<version>${mockito-version}</version>
325+
<scope>test</scope>
315326
</dependency>
316327
</dependencies>
317328
</project>

0 commit comments

Comments
 (0)