bug: historicalDataService.test.js Fails on Unsorted Data

[Aditya8369]

• Description: The test formats daily entries into chronologically ordered CSV... in historicalDataService.test.js implicitly relies on the formatHistoricalCSV function to sort the data. However, the test provides data that is already out of order, and the assertion checks for a specific sorted order. If the function doesn't sort, this test will fail, indicating a fragile test or a missing feature in the function.
• Fix/Enhancement: The formatHistoricalCSV function should internally sort the data by date before creating the CSV string to guarantee chronological order, regardless of the input order.

[github-actions]

👋 Thank you @Aditya8369 for opening this issue!

We appreciate you taking the time to report or suggest an improvement for Pollution Control Hub.

Our maintainers will review your issue as soon as possible.

Meanwhile, please ensure:

• 📌 The issue clearly describes the problem or feature request.
• 📝 Steps to reproduce (if it's a bug) are included.
• 📷 Screenshots or logs are attached when applicable.
• 🔍 The issue is not a duplicate of an existing one.

Thank you for contributing to the project! 🚀

[sanjana2505006]

@Aditya8369 may i take this one?

[github-actions]

Issue is assigned to you, @sanjana2505006! 🎯

⏳ Note: Please submit a working PR within 3 days, else the issue will be unassigned and open for other contributors. 🚀

[sanjana2505006]

@Aditya8369
Looks like this is already fixed on main
formatHistoricalCSV sorts by date with localeCompare before building the CSV (commit 688cf0b). The unsorted-input test in historicalDataService.test.js passes as-is.