Skip to content

R/3.1_season_weightings.R computes seasonally-adjusted values but never writes them #17

Description

@peetmate

Summary

R/3.1_season_weightings.R computes seasonally-adjusted hazard values but appears to never persist them — so it currently produces no output.

Detail

  • The main loop computes value1_adj / value2_adj and runs a negative-value stopifnot (~L212-224), then the loop ends (~L226) with no write_parquet / writeRaster of the adjusted result.
  • The "Legacy - Load cropsuite data" section (L234-295) also computes ex_dat / cs_dat and writes nothing.

So season-weighting is either WIP/parked (no live product) or silently broken (the write step is missing).

Question / action

  • Is season-weighted hazard_exposure meant to be a live, published product?
    • If yes → R/3.1 is unfinished; add the missing write of the adjusted output (and confirm it's in the publish path).
    • If no/WIP → fine to leave; consider marking it WIP to avoid confusion.

Not blocking

Found during the consumer-chain audit for the hazards#19 NDWS historic fix. R/3.1 is skipped in that re-bake (no-op), so this does not block it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions