There is code for several "extension" steps in the repo for this SANDAG ActivitySim consortium example model, but not actually used in the model.
The airport_returns step in airport_returns.py is not used in the example model. It appears it is used in an ancillary airport model that is part of SANDAG's wider modeling system, but that model is not a part of the consortium's example and not officially supported by the consortium.
There is also an external_student_identification step in external_identification.py and an external_school_location step in external_identification.py. As best I can tell, neither of these are actually used anywhere in either the consortium example models OR in SANDAG's published production models. I am not deeply familiar with what is in the SANDAG implementation beyond the consortium supported core models, so it's possible I may be mistaken about potential use within SANDAG.
I propose we remove the entire airport_returns file from the SANDAG consortium example. I also recommend removing the unused external_student_identification and external_school_location code, although if that code is indeed used in some SANDAG model I could be convinced that is is better to leave it so as to keep files in sync.
Referring this specifically to @bhargavasana, @joecastiglione, @dhensle for comment...
There is code for several "extension" steps in the repo for this SANDAG ActivitySim consortium example model, but not actually used in the model.
The
airport_returnsstep inairport_returns.pyis not used in the example model. It appears it is used in an ancillary airport model that is part of SANDAG's wider modeling system, but that model is not a part of the consortium's example and not officially supported by the consortium.There is also an
external_student_identificationstep inexternal_identification.pyand anexternal_school_locationstep inexternal_identification.py. As best I can tell, neither of these are actually used anywhere in either the consortium example models OR in SANDAG's published production models. I am not deeply familiar with what is in the SANDAG implementation beyond the consortium supported core models, so it's possible I may be mistaken about potential use within SANDAG.I propose we remove the entire
airport_returnsfile from the SANDAG consortium example. I also recommend removing the unusedexternal_student_identificationandexternal_school_locationcode, although if that code is indeed used in some SANDAG model I could be convinced that is is better to leave it so as to keep files in sync.Referring this specifically to @bhargavasana, @joecastiglione, @dhensle for comment...