Skip to content

Commit 2d14580

Browse files
committed
fix for PR comments
1 parent fe61a49 commit 2d14580

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

pysp2/util/normalized_derivative_method.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -985,14 +985,9 @@ def compute_normalized_incident_irradiance_moteki_kondo(
985985
- sigma_hat
986986
- tau_best
987987
and ideally fit_start / fit_stop.
988-
h : float, optional
989-
Sampling interval. Required if `t` is not provided.
990-
t : array-like, optional
991-
Explicit time axis to evaluate on. If provided, this is used directly.
992-
n_samples : int, optional
993-
If `t` is not provided, use this many samples starting at 0 with spacing `h`.
994-
If omitted, and `fit_start` / `fit_stop` are present in sigma_out, the function
995-
evaluates only over the fitted window [fit_start, fit_stop).
988+
t_vals : 1D array-like, optional
989+
Explicit time axis (same units as tau_best and sigma_hat). If None,
990+
defaults to 0–39.6 µs at 0.4 µs spacing.
996991
sample_dim : str, default "time"
997992
Name of the returned sample dimension.
998993
@@ -1006,8 +1001,8 @@ def compute_normalized_incident_irradiance_moteki_kondo(
10061001
if "tau_best" not in sigma_out:
10071002
raise ValueError("sigma_out must contain 'tau_best'.")
10081003

1009-
sigma_hat = float(np.asarray(sigma_out["sigma_hat"].values))
1010-
tau_best = float(np.asarray(sigma_out["tau_best"].values))
1004+
sigma_hat = float(np.asarray(sigma_out["sigma_hat"].item()))
1005+
tau_best = float(np.asarray(sigma_out["tau_best"].item()))
10111006

10121007
if not np.isfinite(sigma_hat) or sigma_hat <= 0:
10131008
raise ValueError(f"Invalid sigma_hat={sigma_hat}.")

tests/test_vis.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
my_sp2b = pysp2.io.read_sp2(pysp2.testing.EXAMPLE_SP2B_PSL, arm_convention=False)
1717
my_ini = pysp2.io.read_config(pysp2.testing.EXAMPLE_INI_PSL)
18-
#event = 213
1918
event = 152
2019

2120
@pytest.mark.mpl_image_compare(tolerance=10)

0 commit comments

Comments
 (0)