From 4cd704be3ede108c073280baccc442cdfcf5db35 Mon Sep 17 00:00:00 2001
From: ancplua <anfh22@outlook.com>
Date: Tue, 12 May 2026 15:22:48 +0200
Subject: [PATCH] refactor(esproj): drop Microsoft.VisualStudio.JavaScript.Sdk
 shims
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Replace both PaperlessUI.{Angular,React}.esproj projects with the qyl
hand-rolled MSBuild pattern (qyl/services/qyl.dashboard/qyl.dashboard.esproj),
adapted for pnpm. No more <Project Sdk=...>; custom Restore/Build/Test/Clean
targets shell to pnpm only when RunFrontendOnBuild=true, defaulting to no-op
so CI's dedicated frontend jobs remain the single source of truth.

Removes the entire shim stack that existed only to neutralize the JS SDK:
  - <Project Sdk="Microsoft.VisualStudio.JavaScript.Sdk/1.0.5483906">
  - <ShouldRunBuildScript>false</ShouldRunBuildScript>
  - <ShouldRunNpmInstall>false</ShouldRunNpmInstall>
  - <JavaScriptTestRoot>src\</JavaScriptTestRoot>           (VS-Windows only)
  - <JavaScriptTestFramework>Jasmine|Vitest</...>           (VS-Windows only)
  - <BuildOutputFolder>$(MSBuildProjectDirectory)\dist\...> (backslashes leaked
    literal 'obj\Debug' folders on macOS/Linux every time dotnet build ran)
  - <Build Solution="Debug|*"/> opt-in in Paperless.slnx (only needed because
    the JS SDK ignored projects that weren't explicitly selected per config)

The bootstrap commit (02ce2b3, today 01:34 UTC+2) hand-typed SDK version
1.0.1641815, which is a Visual Studio Windows internal build number from the
IDE's private NuGet feed and never published to nuget.org — that's why
dotnet build outside VS-Windows failed to resolve it. Dropping the SDK
entirely removes the version-pinning fragility for good.

Both projects still surface their source trees to Rider's solution explorer
via <None Include="src/**/*"/> etc., and 'dotnet build Paperless.slnx'
remains green (0 errors). Real frontend builds keep happening in the pnpm CI
jobs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 Paperless.slnx                                |  8 +--
 .../PaperlessUI.Angular.esproj                | 56 ++++++++++++++----
 PaperlessUI.React/PaperlessUI.React.esproj    | 57 +++++++++++++++----
 3 files changed, 95 insertions(+), 26 deletions(-)

diff --git a/Paperless.slnx b/Paperless.slnx
index 88e2c15..22e5342 100644
--- a/Paperless.slnx
+++ b/Paperless.slnx
@@ -5,11 +5,7 @@
   <Project Path="PaperlessREST.Tests/PaperlessREST.Tests.csproj" />
   <Project Path="PaperlessServices.Tests/PaperlessServices.Tests.csproj" />
   <Project Path="PaperlessUI.Blazor/PaperlessUI.Blazor.csproj" />
-  <Project Path="PaperlessUI.Angular/PaperlessUI.Angular.esproj">
-    <Build Solution="Debug|*" />
-  </Project>
-  <Project Path="PaperlessUI.React/PaperlessUI.React.esproj">
-    <Build Solution="Debug|*" />
-  </Project>
+  <Project Path="PaperlessUI.Angular/PaperlessUI.Angular.esproj" />
+  <Project Path="PaperlessUI.React/PaperlessUI.React.esproj" />
   <Project Path="Pipeline/Build.csproj" />
 </Solution>
diff --git a/PaperlessUI.Angular/PaperlessUI.Angular.esproj b/PaperlessUI.Angular/PaperlessUI.Angular.esproj
index 1c0e4a5..31323fc 100644
--- a/PaperlessUI.Angular/PaperlessUI.Angular.esproj
+++ b/PaperlessUI.Angular/PaperlessUI.Angular.esproj
@@ -1,13 +1,49 @@
-<Project Sdk="Microsoft.VisualStudio.JavaScript.Sdk/1.0.5483906">
+<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" DefaultTargets="Build">
+
+  <!--
+    Hand-rolled esproj: drops Microsoft.VisualStudio.JavaScript.Sdk entirely
+    (its versions ship on VS-Windows's private feed; on nuget.org only every
+    Nth build is published — pinning is fragile and the SDK assumes npm).
+    CI builds this project in its own pnpm job (see .github/workflows/ci.yml),
+    so the MSBuild targets below are no-ops by default and exist purely so
+    'dotnet build Paperless.slnx' succeeds and Rider's solution explorer
+    surfaces the directory tree.
+  -->
+
   <PropertyGroup>
-    <StartupCommand>pnpm run start</StartupCommand>
-    <JavaScriptTestRoot>src\</JavaScriptTestRoot>
-    <JavaScriptTestFramework>Jasmine</JavaScriptTestFramework>
-    <!-- Allows the build (or compile) script located on package.json to run on Build -->
-    <ShouldRunBuildScript>false</ShouldRunBuildScript>
-    <!-- pnpm-managed; skip the JS SDK's npm install so dotnet build doesn't clobber pnpm-lock.yaml -->
-    <ShouldRunNpmInstall>false</ShouldRunNpmInstall>
-    <!-- Folder where production build objects will be placed -->
-    <BuildOutputFolder>$(MSBuildProjectDirectory)\dist\paperless-ui-angular</BuildOutputFolder>
+    <FrontendRoot>$(MSBuildProjectDirectory)/</FrontendRoot>
+    <PnpmExe Condition="'$(PnpmExe)' == ''">pnpm</PnpmExe>
+    <DistDir>$(FrontendRoot)dist/paperless-ui-angular</DistDir>
+    <RunFrontendOnBuild Condition="'$(RunFrontendOnBuild)' == ''">false</RunFrontendOnBuild>
   </PropertyGroup>
+
+  <Target Name="Restore">
+    <Message Text="[PaperlessUI.Angular] Restore is a no-op; pnpm install runs in the CI frontend job." Importance="low"/>
+  </Target>
+
+  <Target Name="Build" DependsOnTargets="Restore">
+    <Message Text="[PaperlessUI.Angular] Build is a no-op; pnpm run build runs in the CI frontend job." Importance="low"/>
+    <Exec Command="$(PnpmExe) install --frozen-lockfile=false" WorkingDirectory="$(FrontendRoot)" Condition=" '$(RunFrontendOnBuild)' == 'true' "/>
+    <Exec Command="$(PnpmExe) run build" WorkingDirectory="$(FrontendRoot)" Condition=" '$(RunFrontendOnBuild)' == 'true' "/>
+  </Target>
+
+  <Target Name="Test">
+    <Message Text="[PaperlessUI.Angular] Test is a no-op here; run pnpm test inside the project." Importance="low"/>
+  </Target>
+
+  <Target Name="Clean">
+    <RemoveDir Directories="$(DistDir)" Condition="Exists('$(DistDir)')"/>
+  </Target>
+
+  <ItemGroup>
+    <None Include="package.json"/>
+    <None Include="pnpm-lock.yaml" Condition="Exists('pnpm-lock.yaml')"/>
+    <None Include="angular.json" Condition="Exists('angular.json')"/>
+    <None Include="tsconfig.json" Condition="Exists('tsconfig.json')"/>
+    <None Include="src/**/*"/>
+    <None Include="public/**/*" Condition="Exists('public')"/>
+    <None Remove="node_modules/**"/>
+    <None Remove="dist/**"/>
+  </ItemGroup>
+
 </Project>
diff --git a/PaperlessUI.React/PaperlessUI.React.esproj b/PaperlessUI.React/PaperlessUI.React.esproj
index 55cd96a..2c91422 100644
--- a/PaperlessUI.React/PaperlessUI.React.esproj
+++ b/PaperlessUI.React/PaperlessUI.React.esproj
@@ -1,13 +1,50 @@
-<Project Sdk="Microsoft.VisualStudio.JavaScript.Sdk/1.0.5483906">
+<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" DefaultTargets="Build">
+
+  <!--
+    Hand-rolled esproj: drops Microsoft.VisualStudio.JavaScript.Sdk entirely
+    (its versions ship on VS-Windows's private feed; on nuget.org only every
+    Nth build is published — pinning is fragile and the SDK assumes npm).
+    CI builds this project in its own pnpm job (see .github/workflows/ci.yml),
+    so the MSBuild targets below are no-ops by default and exist purely so
+    'dotnet build Paperless.slnx' succeeds and Rider's solution explorer
+    surfaces the directory tree.
+  -->
+
   <PropertyGroup>
-    <StartupCommand>pnpm run dev</StartupCommand>
-    <JavaScriptTestRoot>src\</JavaScriptTestRoot>
-    <JavaScriptTestFramework>Vitest</JavaScriptTestFramework>
-    <!-- Allows the build (or compile) script located on package.json to run on Build -->
-    <ShouldRunBuildScript>false</ShouldRunBuildScript>
-    <!-- pnpm-managed; skip the JS SDK's npm install so dotnet build doesn't clobber pnpm-lock.yaml -->
-    <ShouldRunNpmInstall>false</ShouldRunNpmInstall>
-    <!-- Folder where production build objects will be placed -->
-    <BuildOutputFolder>$(MSBuildProjectDirectory)\dist</BuildOutputFolder>
+    <FrontendRoot>$(MSBuildProjectDirectory)/</FrontendRoot>
+    <PnpmExe Condition="'$(PnpmExe)' == ''">pnpm</PnpmExe>
+    <DistDir>$(FrontendRoot)dist</DistDir>
+    <RunFrontendOnBuild Condition="'$(RunFrontendOnBuild)' == ''">false</RunFrontendOnBuild>
   </PropertyGroup>
+
+  <Target Name="Restore">
+    <Message Text="[PaperlessUI.React] Restore is a no-op; pnpm install runs in the CI frontend job." Importance="low"/>
+  </Target>
+
+  <Target Name="Build" DependsOnTargets="Restore">
+    <Message Text="[PaperlessUI.React] Build is a no-op; pnpm run build runs in the CI frontend job." Importance="low"/>
+    <Exec Command="$(PnpmExe) install --frozen-lockfile=false" WorkingDirectory="$(FrontendRoot)" Condition=" '$(RunFrontendOnBuild)' == 'true' "/>
+    <Exec Command="$(PnpmExe) run build" WorkingDirectory="$(FrontendRoot)" Condition=" '$(RunFrontendOnBuild)' == 'true' "/>
+  </Target>
+
+  <Target Name="Test">
+    <Message Text="[PaperlessUI.React] Test is a no-op here; run pnpm test inside the project." Importance="low"/>
+  </Target>
+
+  <Target Name="Clean">
+    <RemoveDir Directories="$(DistDir)" Condition="Exists('$(DistDir)')"/>
+  </Target>
+
+  <ItemGroup>
+    <None Include="package.json"/>
+    <None Include="pnpm-lock.yaml" Condition="Exists('pnpm-lock.yaml')"/>
+    <None Include="vite.config.ts" Condition="Exists('vite.config.ts')"/>
+    <None Include="tsconfig.json" Condition="Exists('tsconfig.json')"/>
+    <None Include="index.html" Condition="Exists('index.html')"/>
+    <None Include="src/**/*"/>
+    <None Include="public/**/*" Condition="Exists('public')"/>
+    <None Remove="node_modules/**"/>
+    <None Remove="dist/**"/>
+  </ItemGroup>
+
 </Project>