Use an option or enum variable when using StrMenu

[rvanbekkum]

Maybe this is more something for ALGuideLines.dev or BCQuality, but I'll post it here first and see your thoughts on this.
This is probably something for FormattingCop as it concerns code readability, or maybe even LinterCop as it can also prevent mistakes and improve extensibility.

When you use the StrMenu method, it is good to use an Option (or maybe even an Enum variable if you want it extensible), e.g.:

    procedure StrMenuExample1_NoOption()
    var
        StrMenuTextQst: Label 'Which action do you want to take?';
        StrMenuOptions: Label 'OptionA,OptionB';
    begin
        case StrMenu(StrMenuOptions, 1, StrMenuTextQst) of
            1:
                ; // The action to take for OptionA
            2:
                ; // The action to take for OptionB
            else
                ;
        end;
    end;

    // Already better, more readible
    procedure StrMenuExample2_Option()
    var
        StrMenuTextQst: Label 'Which action do you want to take?';
        SelectedStrMenuOption: Option Cancel,OptionA,OptionB;
        StrMenuOptions: Label 'OptionA,OptionB';
    begin
        // When the StrMenu is opened by default it is set to OptionA
        SelectedStrMenuOption := SelectedStrMenuOption::OptionA;
        SelectedStrMenuOption := StrMenu(StrMenuOptions, SelectedStrMenuOption, StrMenuTextQst);

        case SelectedStrMenuOption of
            SelectedStrMenuOption::OptionA:
                ; // The action to take for OptionA
            SelectedStrMenuOption::OptionB:
                ; // The action to take for OptionB
            SelectedStrMenuOption::Cancel:
                ; // The action to take when the user cancels
            else
                ; // The action to take when somehow we end up with another option
        end;
    end;

    // When extensibility is needed (but using other constructs should also be considered, e.g., a custom page)
    procedure StrMenuExample3_Enum()
    var
        StrMenuTextQst: Label 'Which action do you want to take?';
        SelectedStrMenuOption: Enum MyStrMenuOption;
        StrMenuOption: Enum MyStrMenuOption;
        SelectedStrMenuOptionIndex, SelectedStrMenuOrdinal : Integer;
        StrMenuOptionsTextBuilder: TextBuilder;
        i: Integer;
        IStrMenuOption: Interface IStrMenuOption;
    begin
        // When the StrMenu is opened by default it is set to OptionA
        // Could even add an event publisher for PTEs to set a different default
        SelectedStrMenuOption := SelectedStrMenuOption::OptionA;

        // Build the StrMenu instructions text from the enum members
        i := 0;
        foreach StrMenuOption in Enum::MyStrMenuOption.Ordinals() do begin
            i += 1;
            if StrMenuOption = SelectedStrMenuOption then
                SelectedStrMenuOptionIndex := i;

            if i > 1 then
                StrMenuOptionsTextBuilder.Append(',');
            StrMenuOptionsTextBuilder.Append(Format(StrMenuOption));
        end;
        SelectedStrMenuOptionIndex := StrMenu(StrMenuOptionsTextBuilder.ToText(), SelectedStrMenuOptionIndex, StrMenuTextQst);

        if SelectedStrMenuOptionIndex = 0 then begin
            // Action to take when the user canceled
            exit;
        end;

        // Get the selected enum value by index
        SelectedStrMenuOrdinal := Enum::MyStrMenuOption.Ordinals().Get(SelectedStrMenuOptionIndex);
        SelectedStrMenuOption := Enum::MyStrMenuOption.FromInteger(SelectedStrMenuOrdinal);

        IStrMenuOption := SelectedStrMenuOption;
        IStrMenuOption.TakeAction();
    end;

The StrMenuExample2_Option is the sweet spot, especially when extensibility (adding new options) is not required for the scenario.
It is already much more readable then case StrMenu(..) of 1: ...; it makes the intent much more obvious.