Skip to content

Keep hidden player rows in DOM #90

Description

@hhanon

Is your feature request related to a problem? Please describe.
I have a script on mine that operates directly on the league table (I cant really use leagues_list), so whenever the fought players are hidden the script kind of breaks. It seems that you are removing the player rows from the DOM, which is something my script cant cope with, as the league table is incomplete.

Describe the solution you'd like
Append a class that hides (using display:none) and unhides the fought players rows, instead of removing the elements from the DOM.

Describe alternatives you've considered
I can unhide the rows in my script and then hide them back, but that's quite hacky and prone to break if you decide to rename the button id or the local storage key.

Additional context
I see that you have changed the implementation from what I proposed to the current solution in this commit, but I was hoping that the compatibility problem can be solved without removing the rows from the DOM.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions