Skip to content

Commit 0fd4257

Browse files
committed
Add star on github button and readme changes and fix macos keychain popup (partially)
1 parent f3d3c45 commit 0fd4257

7 files changed

Lines changed: 417 additions & 19 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,16 @@ jobs:
6060
Windows: download the `.msi` or NSIS setup `.exe`.
6161
macOS: download the `.dmg`.
6262
63-
The macOS build uses an ad-hoc signature. macOS may still require
64-
confirmation in Privacy & Security before opening it.
63+
## macOS notice
64+
65+
Because the macOS build is not notarized, you may need to open
66+
System Settings, go to Privacy & Security, and click **Open Anyway**
67+
after trying to launch the app for the first time.
68+
69+
macOS may also show a Keychain access popup. The app stores one
70+
encryption key in its own Keychain entry. Your YouTube session is
71+
encrypted with that key before it is saved in the app data directory.
72+
This popup is expected.
6573
releaseDraft: false
6674
prerelease: false
6775
args: --bundles ${{ matrix.platform.bundles }}

‎README.md‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,20 @@ JustAnotherMusicClient brings YouTube Music to the desktop in a focused, native-
4646
## Download ⏬
4747

4848
Download the **newest available installer** from the [latest release](https://github.com/2latemc/JustAnotherMusicClient/releases/latest) for either Windows or MacOs.
49-
<source
49+
<a href="https://github.com/2latemc/JustAnotherMusicClient/releases/latest">
50+
<picture>
51+
<source
5052
width="831px"
5153
media="(prefers-color-scheme: dark)"
52-
srcset="assets\img\Screenshot02.png"
54+
srcset="assets/img/Screenshot02.png"
5355
>
54-
<img
56+
<img
5557
width="831px"
56-
src="assets\img\Screenshot02.png"
58+
src="assets/img/Screenshot02.png"
59+
alt="Screenshot"
5760
>
61+
</picture>
62+
</a>
5863

5964
## Roadmap 📌
6065
- **Better lyrics consistency** (some songs still don't have them)
@@ -72,7 +77,7 @@ Download the **newest available installer** from the [latest release](https://gi
7277
- **macOS** support is experimental and may have incomplete features or platform-specific issues.
7378
- **Linux** honestly haven't tried it. Should work if you compile it from source? If someone tries let me know!
7479
### MacOs Issues
75-
**MacOs will prompt you with a Keychain popup asking for permission** for the clients keychain folder. This is a specific folder for this application where we can store YouTube Music sign in cookies so that they are stored more securely.
80+
**MacOs may prompt you with a Keychain popup asking for permission.** The app stores one encryption key in its own Keychain entry. Your YouTube Music session is encrypted with that key before it is saved in the app data directory.
7681

7782
If you do not need signing into YouTube Music you dont need to grant Keychain permissions. If you do it is recommended to click "always allow" in the popup to prevent MacOs from being annoying
7883

@@ -142,4 +147,3 @@ Install Rust and Cargo from [rustup.rs](https://rustup.rs/), restart your termin
142147
#### WebView2 is missing
143148

144149
Install the [Microsoft Edge WebView2 Runtime](https://developer.microsoft.com/en-us/microsoft-edge/webview2/), then run the app again.
145-

‎src-tauri/Cargo.lock‎

Lines changed: 139 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src-tauri/Cargo.toml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ base64 = "0.22"
2727
url = "2.5"
2828
keyring = { version = "3.6", features = ["apple-native", "windows-native", "sync-secret-service"] }
2929

30+
[target.'cfg(target_os = "macos")'.dependencies]
31+
aes-gcm = "0.10"
32+
rand = "0.8"
33+
3034
[target.'cfg(target_os = "windows")'.dependencies]
3135
windows = { version = "0.61.3", features = [
3236
"Foundation",

0 commit comments

Comments
 (0)