You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Write-Host "::notice::Windows signing certificate is not configured; building an unsigned installer."
446
+
exit 0
422
447
}
423
-
if ([string]::IsNullOrWhiteSpace($env:WINDOWS_CERTIFICATE_PASSWORD)) {
424
-
throw "WINDOWS_CERTIFICATE_PASSWORD must be configured for public release artifacts."
448
+
if (-not $hasCertificate -or -not $hasPassword) {
449
+
throw "Incomplete Windows signing secrets. Configure both WINDOWS_CERTIFICATE_BASE64 and WINDOWS_CERTIFICATE_PASSWORD, or leave both empty for an unsigned installer."
Copy file name to clipboardExpand all lines: desktop/scripts/check-production-hardening-config.mjs
+18-38Lines changed: 18 additions & 38 deletions
Original file line number
Diff line number
Diff line change
@@ -50,16 +50,18 @@ for (const [workflowName, source] of [
50
50
}
51
51
52
52
assert.match(backendDockerfileSource,/\/ready/,"backend container healthcheck must use the readiness endpoint");
53
-
assert.match(releaseSource,/ValidateWindowssigningsecrets/,"release workflow must validate Windows signing secrets");
54
-
assert.match(releaseSource,/WINDOWS_CERTIFICATE_BASE64/,"release workflow must require a Windows signing certificate");
55
-
assert.match(releaseSource,/CSC_LINK/,"release workflow must pass a signing certificate to electron-builder");
56
-
assert.match(releaseSource,/CSC_KEY_PASSWORD/,"release workflow must pass the Windows signing password to electron-builder");
53
+
assert.match(releaseSource,/PrepareWindowssigningcertificate/,"release workflow must prepare optional Windows signing");
54
+
assert.match(releaseSource,/TASKBRIDGE_WINDOWS_SIGNED_RELEASE/,"release workflow must track whether Windows artifacts are signed");
55
+
assert.match(releaseSource,/CSC_IDENTITY_AUTO_DISCOVERY=false/,"release workflow must explicitly disable Windows signing when no certificate is configured");
56
+
assert.match(releaseSource,/CSC_LINK/,"release workflow must pass a signing certificate to electron-builder when configured");
57
+
assert.match(releaseSource,/CSC_KEY_PASSWORD/,"release workflow must pass the Windows signing password to electron-builder when configured");
0 commit comments