master CI broken: src/cli/commands/menubar.rs + commands_tests.rs compile mismatch since v0.67.0

[factnest365-ops]

Summary

master is broken at the current head 156ae40925 (v0.67.0): the crate fails to compile, which breaks the Build & Test (ubuntu / macos / windows) and Quality Guardrails CI jobs on every pull request.

This is a pre-existing break introduced by the v0.67.0 base (156ae4092), not caused by any open PR. It is independent of PR #758 — #758 stays red in CI only because of this failure.

Exact compile errors

src/cli/commands/menubar.rs — mismatched types (E0308)

• menubar.rs:869 (all platforms)
• menubar.rs:488 (macOS only)

src/cli/commands_tests.rs — mismatched types (E0308)

• commands_tests.rs:262
• commands_tests.rs:296
• commands_tests.rs:323
• commands_tests.rs:263

src/cli/commands_tests.rs — unknown field (E0560)

• commands_tests.rs:408 — struct GateObservation has no field named 'score'
• commands_tests.rs:469 — struct GateObservation has no field named 'score'

Impact

• CI jobs Build & Test (ubuntu, macos, windows) and Quality Guardrails fail on every PR.
• Any open PR (e.g. feat(hooks): support multiple client-scoped commands #758) is blocked in CI even though the failure is not theirs.
• Reproduces on the current master head 156ae40925 (v0.67.0).

Suggested fix

Correct the type mismatches in src/cli/commands/menubar.rs and update the GateObservation construction in src/cli/commands_tests.rs to match the current struct definition (e.g. replace the removed/renamed score field with the field(s) the struct now exposes).

[factnest365-ops]

Fix is ready and verified, awaiting PR submission from a maintainer-capable identity.

The fix for this break is complete and pushed to factnest365-ops/jcode branch fix/menubar-ci (commit 93c5cc9). cargo check --all-targets passes with the fix; the baseline was confirmed broken with exactly the 7 errors documented above.

Root cause: ConfidenceState was migrated from a legacy numeric score to a new enum type; src/cli/commands/menubar.rs and src/cli/commands_tests.rs still construct it with legacy numeric scores (Some(95), score: Some(70), numeric confidence_history), causing E0308/E0560.

To open the PR (one command, from any account with write access to this repo):

gh pr create --repo 1jehuang/jcode --base master --head factnest365-ops:fix/menubar-ci \
  --title "fix(cli): correct menubar command type mismatches on master" \
  --body "Fixes the pre-existing master compile break from this issue. Replaces legacy ConfidenceState numeric scores with the current enum construction (from_legacy_score / state field). cargo check --all-targets verified. Independent of PR #758; unblocks its CI."

This account (factnest365-ops) is pull-only on this repo, so it cannot submit the fork PR itself (GitHub returns FORBIDDEN on createPullRequest). The branch is ready to merge as-is.

[bauerpaul874801]

这个方向很实用，收藏学习了 ⚙️😄😄