Commit 2fe62cf
committed
server: let an unresolvable model contract fail at registration
Review feedback: the catch added in the previous commit swallowed real
model-spec errors. An invalid spec override logged the real reason, started
anyway, and then failed the request with an unrelated "model path does not
exist".
model_accepts_request_option already returns true for a model with no contract
(it swallows only the missing-contract errors and rethrows the rest), so the
catch could only ever extend permissiveness to genuine misconfigurations. It is
removed rather than narrowed: nothing replaces it.
An invalid spec now fails once, at registration, with the real error, instead of
500ing every request as it did before this branch.1 parent df50919 commit 2fe62cf
1 file changed
Lines changed: 10 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1188 | 1188 | | |
1189 | 1189 | | |
1190 | 1190 | | |
1191 | | - | |
1192 | | - | |
1193 | | - | |
1194 | | - | |
1195 | | - | |
1196 | | - | |
1197 | | - | |
1198 | | - | |
1199 | | - | |
1200 | | - | |
1201 | | - | |
1202 | | - | |
1203 | | - | |
1204 | | - | |
1205 | | - | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
1206 | 1201 | | |
1207 | 1202 | | |
1208 | 1203 | | |
| |||
0 commit comments